Issue 10827265: Add Chromoting curtain-mode policy.

Issue 10827265: Add Chromoting curtain-mode policy. (Closed)

Created:
8 years, 4 months ago by Jamie

Modified:
8 years, 4 months ago

Reviewers:
Joao da Silva, Nico, garykac, Mattias Nissler (ping if slow), Nirnimesh

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, sanjeevr, simonmorris+watch_chromium.org, Nirnimesh, wez+watch_chromium.org, amit, hclam+watch_chromium.org, garykac+watch_chromium.org, anantha, dyu1, dennis_jeffrey, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org, lambroslambrou+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add Chromoting curtain-mode policy. BUG=110111 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151350

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reviewer feedback. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -1 line)			Patch
M	chrome/app/policy/policy_templates.json	View	1	2 chunks	+16 lines, -1 line	0 comments	Download
M	chrome/browser/policy/configuration_policy_handler_list.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/pref_names.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/pref_names.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/test/functional/policy_test_cases.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	remoting/host/policy_hack/policy_watcher.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	remoting/host/policy_hack/policy_watcher.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	remoting/host/policy_hack/policy_watcher_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Jamie

Based heavily on http://codereview.chromium.org/10825149/ Gary, ptal at remoting (and in general). Nirnamesh: ptal at chrome/test/functional. ...

8 years, 4 months ago (2012-08-09 23:27:14 UTC) #1

garykac

lgtm (+ suggestion for text) http://codereview.chromium.org/10827265/diff/1/chrome/app/policy/policy_templates.json File chrome/app/policy/policy_templates.json (right): http://codereview.chromium.org/10827265/diff/1/chrome/app/policy/policy_templates.json#newcode519 chrome/app/policy/policy_templates.json:519: If this setting is ...

8 years, 4 months ago (2012-08-09 23:45:21 UTC) #2

Nico

chrome/common lgtm. +joao for policy/ (alternatively: ping for mnissler)

8 years, 4 months ago (2012-08-10 18:20:23 UTC) #3

Jamie

fyi http://codereview.chromium.org/10827265/diff/1/chrome/app/policy/policy_templates.json File chrome/app/policy/policy_templates.json (right): http://codereview.chromium.org/10827265/diff/1/chrome/app/policy/policy_templates.json#newcode519 chrome/app/policy/policy_templates.json:519: If this setting is disabled or not set, ...

8 years, 4 months ago (2012-08-13 17:19:33 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/10827265/3003

8 years, 4 months ago (2012-08-13 17:19:44 UTC) #6

commit-bot: I haz the power

Try job failure for 10827265-3003 (retry) on win_rel for step "interactive_ui_tests". It's a second try, ...

8 years, 4 months ago (2012-08-13 19:29:22 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/10827265/3003

8 years, 4 months ago (2012-08-13 19:59:08 UTC) #8

Change committed as 151350

Expand Messages | Collapse Messages