Issue 10827262: gdata: Remove use of FindEntryByPathSync() from MoveEntryFromRootDirectory()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827262: gdata: Remove use of FindEntryByPathSync() from MoveEntryFromRootDirectory() (Closed)

Created:
8 years, 4 months ago by satorux1

Modified:
8 years, 4 months ago

Reviewers:
achuithb

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Remove use of FindEntryByPathSync() from MoveEntryFromRootDirectory() The number of calles of FindEntryByPathSync() is reduced from 13 to 11. BUG=137694, 126634, 139446 TEST=Moving a file to another directory and renaming in the same directory work as before from file manager. also copying of a hosted document works as before Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151040

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -15 lines)			Patch
	M	chrome/browser/chromeos/gdata/gdata_file_system.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View		1 chunk	+37 lines, -15 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

achuithb

8 years, 4 months ago (2012-08-10 08:46:42 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10827262/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

https://chromiumcodereview.appspot.com/10827262/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_file_system.cc:1268:
scoped_ptr<GDataEntryProto> src_proto = result->first.proto.Pass();
I would've used GDataEntryProto* instead of scoped_ptr here, but I guess this is
fine.

Expand Messages | Collapse Messages