Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10827252: Removing suppressions for CreateMenuModel (leak was fixed). (Closed)

Created:
8 years, 4 months ago by gene
Modified:
8 years, 4 months ago
Reviewers:
oshima
CC:
chromium-reviews, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Removing suppressions for CreateMenuModel (leak was fixed). BUG=141037 TEST=Confirm no memory leaks in ReloadButton. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151131

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M tools/heapcheck/suppressions.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
gene
8 years, 4 months ago (2012-08-09 18:56:44 UTC) #1
oshima
lgtm btw, you may TBR suppression removal.
8 years, 4 months ago (2012-08-10 02:06:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gene@chromium.org/10827252/1
8 years, 4 months ago (2012-08-10 19:17:05 UTC) #3
commit-bot: I haz the power
Failed to apply patch for tools/heapcheck/suppressions.txt: While running patch -p0 --forward --force; patching file tools/heapcheck/suppressions.txt ...
8 years, 4 months ago (2012-08-10 19:17:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gene@chromium.org/10827252/4001
8 years, 4 months ago (2012-08-10 19:26:49 UTC) #5
commit-bot: I haz the power
Try job failure for 10827252-4001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-08-10 20:32:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gene@chromium.org/10827252/4001
8 years, 4 months ago (2012-08-10 20:52:54 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-10 21:56:55 UTC) #8 
Change committed as 151131

Powered by Google App Engine
This is Rietveld 408576698