Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Unified Diff: runtime/bin/bin.gypi

Issue 10827250: Support generating the dart vm snapshot binary on Android (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Incorporate review feedback. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/tools/create_snapshot_bin.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/bin.gypi
diff --git a/runtime/bin/bin.gypi b/runtime/bin/bin.gypi
index e168bfb0463759b0b2ff38c6b4d234d475cfa042..1872c3d073fa62dda69cae42b7b2e17fbcebb70d 100644
--- a/runtime/bin/bin.gypi
+++ b/runtime/bin/bin.gypi
@@ -349,19 +349,48 @@
}]],
},
{
+ # Generate snapshot bin file.
+ 'target_name': 'generate_snapshot_bin',
+ 'type': 'none',
+ 'dependencies': [
+ 'gen_snapshot',
+ ],
+ 'actions': [
+ {
+ 'action_name': 'generate_snapshot_bin',
+ 'inputs': [
+ '../tools/create_snapshot_bin.py',
+ '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)gen_snapshot<(EXECUTABLE_SUFFIX)',
+ ],
+ 'outputs': [
+ '<(snapshot_bin_file)',
+ ],
+ 'action': [
+ 'python',
+ 'tools/create_snapshot_bin.py',
+ '--executable',
+ '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)gen_snapshot<(EXECUTABLE_SUFFIX)',
+ '--output_bin', '<(snapshot_bin_file)',
+ '--target_os', '<(OS)'
+ ],
+ 'message': 'Generating ''<(snapshot_bin_file)'' file.'
+ },
+ ],
+ },
+ {
# Generate snapshot file.
'target_name': 'generate_snapshot_file',
'type': 'none',
'dependencies': [
- 'gen_snapshot',
+ 'generate_snapshot_bin',
],
'actions': [
{
'action_name': 'generate_snapshot_file',
'inputs': [
'../tools/create_snapshot_file.py',
- '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)gen_snapshot<(EXECUTABLE_SUFFIX)',
'<(snapshot_in_cc_file)',
+ '<(snapshot_bin_file)'
],
'outputs': [
'<(snapshot_cc_file)',
@@ -369,8 +398,7 @@
'action': [
'python',
'tools/create_snapshot_file.py',
- '--executable', '<(PRODUCT_DIR)/gen_snapshot',
- '--output_bin', '<(snapshot_bin_file)',
+ '--input_bin', '<(snapshot_bin_file)',
'--input_cc', '<(snapshot_in_cc_file)',
'--output', '<(snapshot_cc_file)',
],
« no previous file with comments | « no previous file | runtime/tools/create_snapshot_bin.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698