Support generating the dart vm snapshot binary on Android

runtime/bin/bin.gypi

 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 {
   'variables': {
     'crypto_cc_file': '<(SHARED_INTERMEDIATE_DIR)/crypto_gen.cc',
     'io_cc_file': '<(SHARED_INTERMEDIATE_DIR)/io_gen.cc',
     'json_cc_file': '<(SHARED_INTERMEDIATE_DIR)/json_gen.cc',
     'uri_cc_file': '<(SHARED_INTERMEDIATE_DIR)/uri_gen.cc',
@@ skipping 331 matching lines @@
         '<(web_cc_file)',
       ],
       'conditions': [
         ['OS=="win"', {
           'link_settings': {
             'libraries': [ '-lws2_32.lib', '-lRpcrt4.lib' ],
           },
        }]],
     },
     {
+      # Generate snapshot bin file.
+      'target_name': 'generate_snapshot_bin',
+      'type': 'none',
+      'dependencies': [
+        'gen_snapshot',
+      ],
+      'actions': [
+        {
+          'action_name': 'generate_snapshot_bin',
+          'inputs': [
+            '../tools/create_snapshot_bin.py',
+            '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)gen_snapshot<(EXECUTABLE_SUFFIX)',
+          ],
+          'outputs': [
+            '<(snapshot_bin_file)',
+          ],
+          'action': [
+            'python',
+            'tools/create_snapshot_bin.py',

[ahe, 2012/08/09 20:57:16]

This doesn't match line 362. Are you sure the dependencies are right?

I know there is a problem because this gypi file is included by a gyp file one
directory up.

[jackpal, 2012/08/13 20:19:45]

See the discussion below. This line is correct as written,
due to this gypi file being included from one directory up.

+            '--executable', '<(PRODUCT_DIR)/gen_snapshot',

[ahe, 2012/08/09 20:57:16]

This should match line 363.

[jackpal, 2012/08/13 20:19:45]

Done.

+            '--output_bin', '<(snapshot_bin_file)',
+            '--target_os', '<(OS)'
+          ],
+          'message': 'Generating ''<(snapshot_bin_file)'' file.'
+        },
+      ],
+    },
+    {
       # Generate snapshot file.
       'target_name': 'generate_snapshot_file',
       'type': 'none',
       'dependencies': [
-        'gen_snapshot',
+        'generate_snapshot_bin',
       ],
       'actions': [
         {
           'action_name': 'generate_snapshot_file',
           'inputs': [
             '../tools/create_snapshot_file.py',
-            '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)gen_snapshot<(EXECUTABLE_SUFFIX)',
             '<(snapshot_in_cc_file)',
+            '<(snapshot_bin_file)'
           ],
           'outputs': [
             '<(snapshot_cc_file)',
           ],
           'action': [
             'python',
             'tools/create_snapshot_file.py',

[ahe, 2012/08/09 20:57:16]

This doesn't match line 390.

[Ivan Posva, 2012/08/09 21:48:15]

I agree with Peter that the paths in input and action sections should match.
Please fix.

[jackpal, 2012/08/13 20:19:45]

Ivan and I discussed this and came to the conclusion that the current code is
correct.

action scripts are executed relative to the directory where the top-level .gyp
file is run, while dependencies and essentially all other file references while
running gyp are resolved relative to gyp[i] file containing them.

-            '--executable', '<(PRODUCT_DIR)/gen_snapshot',
-            '--output_bin', '<(snapshot_bin_file)',
+            '--input_bin', '<(snapshot_bin_file)',
             '--input_cc', '<(snapshot_in_cc_file)',
             '--output', '<(snapshot_cc_file)',
           ],
           'message': 'Generating ''<(snapshot_cc_file)'' file.'
         },
       ]
     },
     {
       # dart binary with a snapshot of corelibs built in.
       'target_name': 'dart',
@@ skipping 141 matching lines @@
         ['OS=="mac"', {
           'xcode_settings': {
             'OTHER_LDFLAGS': [ '-undefined', 'dynamic_lookup' ],
           },
         }],
       ],
     },
   ],
 }