vm/heap_profiler.cc - Issue 10827249: - Register canonical names for internal VM classes and get rid of the method GetSingletonClassName

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: vm/heap_profiler.cc

Issue 10827249: - Register canonical names for internal VM classes and get rid of the method GetSingletonClassName (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: vm/heap_profiler.cc

===================================================================

--- vm/heap_profiler.cc (revision 10528)

+++ vm/heap_profiler.cc (working copy)

@@ -412,13 +412,8 @@

record.WritePointer(raw_class);

// stack trace serial number

record.Write32(0);

- if (raw_class->ptr()->name_ == String::null()) {

- intptr_t class_id = raw_class->ptr()->id_;

- const char* name = Object::GetSingletonClassName(class_id);

- record.WritePointer(StringId(name));

- } else {

- record.WritePointer(StringId(raw_class->ptr()->name_));

- }

+ ASSERT(raw_class->ptr()->name_ != String::null());

+ record.WritePointer(StringId(raw_class->ptr()->name_));

}

« no previous file with comments | « vm/code_generator.cc ('k') | vm/object.h » ('j') | no next file with comments »