Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Unified Diff: vm/object.h

Issue 10827249: - Register canonical names for internal VM classes and get rid of the method GetSingletonClassName (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/heap_profiler.cc ('k') | vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/object.h
===================================================================
--- vm/object.h (revision 10450)
+++ vm/object.h (working copy)
@@ -235,6 +235,7 @@
}
static RawObject* null() { return null_; }
+ static RawArray* empty_array() { return empty_array_; }
srdjan 2012/08/09 18:43:54 Maybe replace all Array::Empty() with Object::empt
siva 2012/08/10 00:37:05 Done.
// The sentinel is a value that cannot be produced by Dart code.
// It can be used to mark special values, for example to distinguish
@@ -284,8 +285,6 @@
static RawClass* icdata_class() { return icdata_class_; }
static RawClass* subtypetestcache_class() { return subtypetestcache_class_; }
- static const char* GetSingletonClassName(intptr_t class_id);
-
static RawClass* CreateAndRegisterInterface(const char* cname,
const Script& script,
const Library& lib);
@@ -302,6 +301,7 @@
static RawError* Init(Isolate* isolate);
static void InitFromSnapshot(Isolate* isolate);
static void InitOnce();
+ static void RegisterSingletonClassNames();
static intptr_t InstanceSize() {
return RoundedAllocationSize(sizeof(RawObject));
@@ -376,6 +376,7 @@
// The static values below are singletons shared between the different
// isolates. They are all allocated in the non-GC'd Dart::vm_isolate_.
static RawObject* null_;
+ static RawArray* empty_array_;
static RawInstance* sentinel_;
static RawInstance* transition_sentinel_;
@@ -687,6 +688,9 @@
void Finalize() const;
+ // Initialize the functions cache array.
+ void InitFunctionsCache() const;
+
// Allocate a class used for VM internal objects.
template <class FakeObject> static RawClass* New();
« no previous file with comments | « vm/heap_profiler.cc ('k') | vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698