Issue 10827234: Fix Search key incorrectly recognized as Alt by the keyboard overlay.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827234: Fix Search key incorrectly recognized as Alt by the keyboard overlay. (Closed)

Created:
8 years, 4 months ago by mazda

Modified:
8 years, 4 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix Search key incorrectly recognized as Alt by the keyboard overlay. 91 is a keycode sent when Search key is pressed. The issue these keycodes are added for (http://crosbug.com/14236) is no longer reproducible, so they are safely removed. BUG=141211 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150663

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	chrome/browser/resources/chromeos/keyboard_overlay.js	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/10827234/1

8 years, 4 months ago (2012-08-08 21:57:32 UTC) #3

Change committed as 150663