Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/testing/run_selenium.py

Issue 10827232: More robust exit test for Dromaeo (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/run_selenium.py
diff --git a/tools/testing/run_selenium.py b/tools/testing/run_selenium.py
index a95f4c6ebacfe59e560a8ce7226b1ab95988ccbd..3ec94bce6c9f7fddecce9ed74ee7fcc36a892cd6 100755
--- a/tools/testing/run_selenium.py
+++ b/tools/testing/run_selenium.py
@@ -58,11 +58,7 @@ def perf_test_done(source):
def dromaeo_test_done(source):
"""Tests to see if our performance test is done by printing a score."""
#TODO(efortuna): Access these elements in a nicer way using DOM parser.
- string = '<span class="left">'
- index = source.find(string)
- end_index = source.find('</span>', index+1)
- source = source[index + len(string):end_index]
- return '0:00' in source
+ return '<body class="alldone">' in source
# TODO(vsm): Ideally, this wouldn't live in this file.
CONFIGURATIONS = {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698