Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 10827231: Sync the client (Chrome) version of the SafeBrowsing csd protocol buffer definition with the versio… (Closed)

Created:
8 years, 4 months ago by noelutz
Modified:
8 years, 4 months ago
Reviewers:
panayiotis, jam, mattm
CC:
chromium-reviews
Visibility:
Public.

Description

Sync the client (Chrome) version of the SafeBrowsing csd protocol buffer definition with the version we have on the server. This change adds a couple of fields which will be used by Chrome on Android to display custom SafeBrowsing warnings. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150821

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M chrome/common/safe_browsing/csd.proto View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
noelutz
8 years, 4 months ago (2012-08-08 20:55:03 UTC) #1
panayiotis
lgtm
8 years, 4 months ago (2012-08-08 20:59:00 UTC) #2
mattm
lgtm
8 years, 4 months ago (2012-08-08 21:24:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelutz@google.com/10827231/1
8 years, 4 months ago (2012-08-08 21:29:47 UTC) #4
commit-bot: I haz the power
Presubmit check for 10827231-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-08 21:29:50 UTC) #5
noelutz
Hi John, I need owners LGTM for this change to common/safe_browsing. Thanks, noé.
8 years, 4 months ago (2012-08-08 21:33:21 UTC) #6
jam
lgtm
8 years, 4 months ago (2012-08-08 23:34:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelutz@google.com/10827231/1
8 years, 4 months ago (2012-08-09 15:24:14 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 17:03:40 UTC) #9
Change committed as 150821

Powered by Google App Engine
This is Rietveld 408576698