Issue 10827220: Fix handling of accessors on trunk. This is a combination of

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827220: Fix handling of accessors on trunk. This is a combination of (Closed)

Created:
8 years, 4 months ago by Erik Corry

Modified:
8 years, 4 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix handling of accessors on trunk. This is a combination of r12271, r12264 and r12247, and is intended to fix bugs 140473, 140430 and 138388. Unfortunately it probably breaks the MIPS port. Committed: https://code.google.com/p/v8/source/detail?r=12277

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+326 lines, -42 lines)			Patch
M	src/arm/stub-cache-arm.cc	View		2 chunks	+41 lines, -0 lines	0 comments	Download
M	src/bootstrapper.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/heap.cc	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View		7 chunks	+28 lines, -7 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View		2 chunks	+41 lines, -0 lines	0 comments	Download
M	src/ic.cc	View		6 chunks	+7 lines, -6 lines	0 comments	Download
M	src/objects.h	View		3 chunks	+10 lines, -1 line	0 comments	Download
M	src/objects.cc	View		7 chunks	+8 lines, -1 line	0 comments	Download
M	src/objects-inl.h	View		2 chunks	+12 lines, -0 lines	0 comments	Download
M	src/stub-cache.h	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/type-info.cc	View		2 chunks	+11 lines, -8 lines	0 comments	Download
M	src/version.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/stub-cache-x64.cc	View		2 chunks	+42 lines, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View		3 chunks	+105 lines, -18 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 4 months ago (2012-08-08 14:41:19 UTC) #2

LGTM (reviewed version.cc, rubber-stamped the rest).

Expand Messages | Collapse Messages