Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 10827218: Replace gfx::ScopedSkRegion with scoped_ptr<SkRegion>. (Closed)

Created:
8 years, 4 months ago by Junmin Zhu
Modified:
8 years, 4 months ago
CC:
chromium-reviews, jeremya+watch_chromium.org, Aaron Boodman, mihaip-chromium-reviews_chromium.org, tfarina
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Replace gfx::ScopedSkRegion with scoped_ptr<SkRegion>. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150742

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/ui/views/extensions/shell_window_views.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/shell_window_views.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Junmin Zhu
replace gfx::ScopedSkRegion with general scoped_ptr<SkRegion>. Please kindly review the patch. Thanks.
8 years, 4 months ago (2012-08-08 13:40:02 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-08-08 21:30:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junmin.zhu@intel.com/10827218/1
8 years, 4 months ago (2012-08-09 00:28:29 UTC) #3
commit-bot: I haz the power
Try job failure for 10827218-1 (retry) (retry) (retry) on linux_rel for step "nacl_integration". It's a ...
8 years, 4 months ago (2012-08-09 02:19:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junmin.zhu@intel.com/10827218/1
8 years, 4 months ago (2012-08-09 02:33:25 UTC) #5
commit-bot: I haz the power
Try job failure for 10827218-1 (retry) on mac_rel for step "check_deps". It's a second try, ...
8 years, 4 months ago (2012-08-09 03:23:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junmin.zhu@intel.com/10827218/1
8 years, 4 months ago (2012-08-09 03:45:24 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 05:22:29 UTC) #8
Change committed as 150742

Powered by Google App Engine
This is Rietveld 408576698