Issue 10827216: Don't run BrowserPolicyConnector::Init from TestingBrowserProcess by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827216: Don't run BrowserPolicyConnector::Init from TestingBrowserProcess by default. (Closed)

Created:
8 years, 4 months ago by Joao da Silva

Modified:
8 years, 4 months ago

Reviewers:
Nikita (slow), Andrew T Wilson (Slow), Mattias Nissler (ping if slow), Paweł Hajdan Jr.

CC:
chromium-reviews, timurrrr+watch_chromium.org, nkostylev+watch_chromium.org, glider+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't run BrowserPolicyConnector::Init from TestingBrowserProcess by default. Tests that need internal stuff from the connector should run Init() from SetUp, or should be built as an InProcessBrowserTest instead. BUG=141255, 66054 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150764

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Fix tests #

Patch Set 4 : Plug leak #

Patch Set 5 : Rebased #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -127 lines)			Patch
M	chrome/browser/chromeos/login/login_utils_browsertest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/browser_policy_connector.cc	View	1	3 chunks	+1 line, -12 lines	0 comments	Download
M	chrome/browser/policy/config_dir_policy_loader.cc	View		2 chunks	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/policy/user_cloud_policy_store_unittest.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/user_policy_signin_service_unittest.cc	View	1 2 3	5 chunks	+13 lines, -7 lines	0 comments	Download
M	chrome/test/base/testing_browser_process.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	tools/heapcheck/suppressions.txt	View	1 2 3 4	2 chunks	+0 lines, -88 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	1 2 3 4	1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mattias Nissler (ping if slow)

LGTM. Let's commit this for the time being to get rid of the leaks. We ...

8 years, 4 months ago (2012-08-08 15:00:27 UTC) #2

Joao da Silva

@phajdan.jr: please review chrome/test @nkostylev: please review chrome/browser/chromeos/login Thanks!

8 years, 4 months ago (2012-08-08 16:59:06 UTC) #3

lgtm

Expand Messages | Collapse Messages