GYP changes for Clang/Android build.

GYP changes for Clang/Android build.

TEST=none
BUG=137569
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150779

[Yaron, 2012-08-08 15:30:10]

lg for Android but adding Ami to see if this might affect CrOs.

[Ami GONE FROM CHROMIUM, 2012-08-08 16:30:21]

drive-by LGTM % moving the flag suppression under an android condition.

https://chromiumcodereview.appspot.com/10827214/diff/2001/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/10827214/diff/2001/build/common.gypi#n...
build/common.gypi:2226: ['clang==1', {
This only suppresses flags added in OS=="android" conditions, so doing this
suppression *outside* an android block seems unnecessarily general to me (and
likelier to drive a revert as an unrelated config gets messed up in a surprising
way).
I would just put this under the android section several lines down.

[eugenis, 2012-08-09 09:34:47]

https://chromiumcodereview.appspot.com/10827214/diff/2001/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/10827214/diff/2001/build/common.gypi#n...
build/common.gypi:2226: ['clang==1', {
On 2012/08/08 16:30:21, Ami Fischman wrote:
> This only suppresses flags added in OS=="android" conditions, so doing this
> suppression *outside* an android block seems unnecessarily general to me (and
> likelier to drive a revert as an unrelated config gets messed up in a
surprising
> way).
> I would just put this under the android section several lines down.

Done.

[commit-bot: I haz the power, 2012-08-09 09:37:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eugenis@chromium.org/10827214/6001

[commit-bot: I haz the power, 2012-08-09 10:44:08]

Change committed as 150779