Fix mem leak in DirectoryBackingStore unit tests

sync/syncable/on_disk_directory_backing_store.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/syncable/on_disk_directory_backing_store.h"
 
 #include "base/logging.h"
+#include "base/stl_util.h"
 #include "base/metrics/histogram.h"
 #include "sync/syncable/syncable-inl.h"
 
 namespace syncer {
 namespace syncable {
 
 namespace {
 
 enum HistogramResultEnum {
   FIRST_TRY_SUCCESS,
@@ skipping 47 matching lines @@
   if (result == OPENED) {
     HISTOGRAM_ENUMERATION(
         "Sync.DirectoryOpenResult", FIRST_TRY_SUCCESS, RESULT_COUNT);
     return OPENED;
   }
 
   ReportFirstTryOpenFailure();
 
   // The fallback: delete the current database and return a fresh one.  We can
   // fetch the user's data from the could.
-  entry_bucket->clear();
+  STLDeleteElements(entry_bucket);
   db_.reset(new sql::Connection);
   file_util::Delete(backing_filepath_, false);
 
   result = TryLoad(entry_bucket, kernel_load_info);
   if (result == OPENED) {
     HISTOGRAM_ENUMERATION(
         "Sync.DirectoryOpenResult", SECOND_TRY_SUCCESS, RESULT_COUNT);
   } else {
     HISTOGRAM_ENUMERATION(
         "Sync.DirectoryOpenResult", SECOND_TRY_FAILURE, RESULT_COUNT);
   }
 
   return result;
 }
 
 void OnDiskDirectoryBackingStore::ReportFirstTryOpenFailure() {
   // In debug builds, the last thing we want is to silently clear the database.
   // It's full of evidence that might help us determine what went wrong.  It
   // might be sqlite's fault, but it could also be a bug in sync.  We crash
   // immediately so a developer can investigate.
   //
   // Developers: If you're not interested in debugging this right now, just move
   // aside the 'Sync Data' directory in your profile.  This is similar to what
   // the code would do if this DCHECK were disabled.
   NOTREACHED() << "Crashing to preserve corrupt sync database";
 }
 
 }  // namespace syncable
 }  // namespace syncer