Issue 10827210: Set the user gesture when executing script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827210: Set the user gesture when executing script. (Closed)

Created:
8 years, 4 months ago by brettw

Modified:
8 years, 4 months ago

Reviewers:
raymes

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Set the user gesture when executing script. This is just like r145992 but for a different call site. If the script executing creates a popup, we want the user gesture flag to be set correctly to allow user-initiated popups. BUG=130178 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150468

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View		1 chunk	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/10827210/1

8 years, 4 months ago (2012-08-07 22:59:05 UTC) #3

Change committed as 150468

Expand Messages | Collapse Messages