Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 10827204: Test within-page navigation. (Closed)

Created:
8 years, 4 months ago by Jeffrey Yasskin
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Test within-page navigation for page actions. BUG=139410 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150566

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/extensions/page_action_controller_unittest.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jeffrey Yasskin
That was easier than I expected. The downside is that it doesn't automatically catch the ...
8 years, 4 months ago (2012-08-07 21:16:41 UTC) #1
not at google - send to devlin
I don't understand what you mean by "moving the notification observer to another class", but ...
8 years, 4 months ago (2012-08-08 07:42:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/10827204/1
8 years, 4 months ago (2012-08-08 15:07:38 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-08 16:31:51 UTC) #4
Change committed as 150566

Powered by Google App Engine
This is Rietveld 408576698