Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 10827203: Deselect should maintain previously selected wallpaper and guest should load default guest wallpaper (Closed)

Created:
8 years, 4 months ago by bshe
Modified:
8 years, 4 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Deselect should maintain previously selected wallpaper and select guest user should use default guest wallpaper Deselect user from user pod should not set the wallpaper to a white background. It should use whatever wallpaper is showing. It also fix the problem when selecting guest user pod, the wallpaper didn't set to default guest user wallpaper. BUG=141259, 141226 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150801

Patch Set 1 #

Patch Set 2 : Deselection = noop and guest user should use default guest user wallpaper #

Patch Set 3 : nit #

Total comments: 1

Patch Set 4 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M chrome/browser/chromeos/login/wallpaper_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager.cc View 1 2 3 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bshe
Hi Nikita. could you please take a look? Wallpaper stay as white wallpaper when new ...
8 years, 4 months ago (2012-08-08 15:38:57 UTC) #1
bshe
Hi Nikita. Pre discussion: Now the deselection didn't do anything. and click on guest user ...
8 years, 4 months ago (2012-08-08 16:39:55 UTC) #2
Nikita (slow)
lgtm https://chromiumcodereview.appspot.com/10827203/diff/7001/chrome/browser/chromeos/login/wallpaper_manager.cc File chrome/browser/chromeos/login/wallpaper_manager.cc (right): https://chromiumcodereview.appspot.com/10827203/diff/7001/chrome/browser/chromeos/login/wallpaper_manager.cc#newcode365 chrome/browser/chromeos/login/wallpaper_manager.cc:365: nit: drop empty line.
8 years, 4 months ago (2012-08-08 16:51:24 UTC) #3
Nikita (slow)
Please request merge for this CL.
8 years, 4 months ago (2012-08-08 16:51:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/10827203/2005
8 years, 4 months ago (2012-08-09 14:36:23 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 15:51:24 UTC) #6
Change committed as 150801

Powered by Google App Engine
This is Rietveld 408576698