chrome/browser/ui/views/toolbar_view.h - Issue 10827198: Change View::HitTest to View::HitTestRect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar_view.h

Issue 10827198: Change View::HitTest to View::HitTestRect (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Revised patch with tests added Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/toolbar_view.h

diff --git a/chrome/browser/ui/views/toolbar_view.h b/chrome/browser/ui/views/toolbar_view.h

index 0d6836991736cbe6690c8088ecc51ecca95a3b40..d02a47a9b6fb99b811b60c8a5d493792abdda8b7 100644

--- a/chrome/browser/ui/views/toolbar_view.h

+++ b/chrome/browser/ui/views/toolbar_view.h

@@ -146,7 +146,7 @@ class ToolbarView : public views::AccessiblePaneView,

// Overridden from views::View:

virtual gfx::Size GetPreferredSize() OVERRIDE;

virtual void Layout() OVERRIDE;

- virtual bool HitTest(const gfx::Point& l) const OVERRIDE;

+ virtual bool HitTestRect(const gfx::Rect& rect) const OVERRIDE;

virtual void OnPaint(gfx::Canvas* canvas) OVERRIDE;

virtual bool GetDropFormats(

int* formats,