chrome/browser/ui/views/tabs/base_tab.cc - Issue 10827198: Change View::HitTest to View::HitTestRect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/base_tab.cc

Issue 10827198: Change View::HitTest to View::HitTestRect (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Revised patch with tests added Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/tabs/base_tab.cc

diff --git a/chrome/browser/ui/views/tabs/base_tab.cc b/chrome/browser/ui/views/tabs/base_tab.cc

index 0f9edce6c9766b469936d91ba931c96209b5e30f..f1a8c8a4c41c856d828fd2a105d4bee2a213164c 100644

--- a/chrome/browser/ui/views/tabs/base_tab.cc

+++ b/chrome/browser/ui/views/tabs/base_tab.cc

@@ -361,7 +361,7 @@ void BaseTab::OnMouseReleased(const views::MouseEvent& event) {

// (normal windows behavior is to discard presses of a UI element where the

// releases happen off the element).

if (event.IsMiddleMouseButton()) {

- if (HitTest(event.location())) {

+ if (HitTestPoint(event.location())) {

controller()->CloseTab(this);

} else if (closing_) {

// We're animating closed and a middle mouse button was pushed on us but