Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6251)

Unified Diff: chrome/browser/ui/views/omnibox/inline_omnibox_popup_view.cc

Issue 10827198: Change View::HitTest to View::HitTestRect (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Revised patch with tests added Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/omnibox/inline_omnibox_popup_view.cc
diff --git a/chrome/browser/ui/views/omnibox/inline_omnibox_popup_view.cc b/chrome/browser/ui/views/omnibox/inline_omnibox_popup_view.cc
index d834ee9abcd58564e6cbe332b9fa6ec4f7a66611..f88a41ae01e84250e017d5a29e1fe14850526202 100644
--- a/chrome/browser/ui/views/omnibox/inline_omnibox_popup_view.cc
+++ b/chrome/browser/ui/views/omnibox/inline_omnibox_popup_view.cc
@@ -359,7 +359,7 @@ void InlineOmniboxPopupView::OpenIndex(size_t index,
}
size_t InlineOmniboxPopupView::GetIndexForPoint(const gfx::Point& point) {
- if (!HitTest(point))
+ if (!HitTestPoint(point))
return OmniboxPopupModel::kNoMatch;
int nb_match = model_->result().size();
@@ -368,7 +368,7 @@ size_t InlineOmniboxPopupView::GetIndexForPoint(const gfx::Point& point) {
views::View* child = child_at(i);
gfx::Point point_in_child_coords(point);
View::ConvertPointToView(this, child, &point_in_child_coords);
- if (child->HitTest(point_in_child_coords))
+ if (child->HitTestPoint(point_in_child_coords))
return i;
}
return OmniboxPopupModel::kNoMatch;

Powered by Google App Engine
This is Rietveld 408576698