chrome/browser/ui/views/content_setting_bubble_contents.cc - Issue 10827198: Change View::HitTest to View::HitTestRect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/content_setting_bubble_contents.cc

Issue 10827198: Change View::HitTest to View::HitTestRect (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Revised patch with tests added Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/content_setting_bubble_contents.cc

diff --git a/chrome/browser/ui/views/content_setting_bubble_contents.cc b/chrome/browser/ui/views/content_setting_bubble_contents.cc

index 3840b00fa3586470f03722420e7354b1fdd2be24..91ef8a23cf5f024f5b5967a3da95b01f2cb75576 100644

--- a/chrome/browser/ui/views/content_setting_bubble_contents.cc

+++ b/chrome/browser/ui/views/content_setting_bubble_contents.cc

@@ -80,7 +80,7 @@ bool ContentSettingBubbleContents::Favicon::OnMousePressed(

void ContentSettingBubbleContents::Favicon::OnMouseReleased(

const views::MouseEvent& event) {

if ((event.IsLeftMouseButton() || event.IsMiddleMouseButton()) &&

- HitTest(event.location())) {

+ HitTestPoint(event.location())) {

parent_->LinkClicked(link_, event.flags());

}