Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4580)

Unified Diff: chrome/browser/ui/views/tabs/tab_unittest.cc

Issue 10827198: Change View::HitTest to View::HitTestRect (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fixed errors reported by trybots Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_strip.cc ('k') | chrome/browser/ui/views/toolbar_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/tabs/tab_unittest.cc
diff --git a/chrome/browser/ui/views/tabs/tab_unittest.cc b/chrome/browser/ui/views/tabs/tab_unittest.cc
index 289685fd76de234f24dd2e37da5b4ee6a363ebe5..9c7614e8863b9ce0083e11e680e4b19e37070ea3 100644
--- a/chrome/browser/ui/views/tabs/tab_unittest.cc
+++ b/chrome/browser/ui/views/tabs/tab_unittest.cc
@@ -76,18 +76,18 @@ TEST_F(TabTest, HitTestTopPixel) {
// Tabs have some shadow in the top, so by default we don't hit the tab there.
int middle_x = tab.width() / 2;
- EXPECT_FALSE(tab.HitTest(gfx::Point(middle_x, 0)));
+ EXPECT_FALSE(tab.HitTestPoint(gfx::Point(middle_x, 0)));
// Tabs are slanted, so a click halfway down the left edge won't hit it.
int middle_y = tab.height() / 2;
- EXPECT_FALSE(tab.HitTest(gfx::Point(0, middle_y)));
+ EXPECT_FALSE(tab.HitTestPoint(gfx::Point(0, middle_y)));
// If the window is maximized, however, we want clicks in the top edge to
// select the tab.
widget.Maximize();
- EXPECT_TRUE(tab.HitTest(gfx::Point(middle_x, 0)));
+ EXPECT_TRUE(tab.HitTestPoint(gfx::Point(middle_x, 0)));
// But clicks in the area above the slanted sides should still miss.
- EXPECT_FALSE(tab.HitTest(gfx::Point(0, 0)));
- EXPECT_FALSE(tab.HitTest(gfx::Point(tab.width() - 1, 0)));
+ EXPECT_FALSE(tab.HitTestPoint(gfx::Point(0, 0)));
+ EXPECT_FALSE(tab.HitTestPoint(gfx::Point(tab.width() - 1, 0)));
}
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_strip.cc ('k') | chrome/browser/ui/views/toolbar_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698