chrome/browser/ui/views/frame/glass_browser_frame_view.cc - Issue 10827198: Change View::HitTest to View::HitTestRect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/glass_browser_frame_view.cc

Issue 10827198: Change View::HitTest to View::HitTestRect (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fixed errors reported by trybots Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/glass_browser_frame_view.cc

diff --git a/chrome/browser/ui/views/frame/glass_browser_frame_view.cc b/chrome/browser/ui/views/frame/glass_browser_frame_view.cc

index 0bed418bc3714dd40579b1295342e52b7a3bd92d..a688915524148dd53f109df7ffee4303a898e9f6 100644

--- a/chrome/browser/ui/views/frame/glass_browser_frame_view.cc

+++ b/chrome/browser/ui/views/frame/glass_browser_frame_view.cc

@@ -242,10 +242,10 @@ void GlassBrowserFrameView::Layout() {

LayoutClientView();

}

-bool GlassBrowserFrameView::HitTest(const gfx::Point& l) const {

+bool GlassBrowserFrameView::HitTestRect(const gfx::Rect& rect) const {

return (avatar_button() &&

- avatar_button()->GetMirroredBounds().Contains(l)) ||

- !frame()->client_view()->bounds().Contains(l);

+ avatar_button()->GetMirroredBounds().Intersects(rect)) ||

+ !frame()->client_view()->bounds().Intersects(rect);

}

///////////////////////////////////////////////////////////////////////////////