chrome/browser/ui/views/location_bar/page_info_helper.cc - Issue 10827198: Change View::HitTest to View::HitTestRect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/page_info_helper.cc

Issue 10827198: Change View::HitTest to View::HitTestRect (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/location_bar/page_info_helper.cc

diff --git a/chrome/browser/ui/views/location_bar/page_info_helper.cc b/chrome/browser/ui/views/location_bar/page_info_helper.cc

index b350cd6f60fe698c0d513ef784d5e5a61e1a30ee..f76ccc765c2550771afebbadfb01eecf73d73640 100644

--- a/chrome/browser/ui/views/location_bar/page_info_helper.cc

+++ b/chrome/browser/ui/views/location_bar/page_info_helper.cc

@@ -23,7 +23,7 @@ PageInfoHelper::PageInfoHelper(const views::View* owner,

}

void PageInfoHelper::ProcessEvent(const views::LocatedEvent& event) {

- if (!owner_->HitTest(event.location()))

+ if (!owner_->HitTest(gfx::Rect(event.location(), gfx::Size(0, 0))))

return;

// Do not show page info if the user has been editing the location