Change View::HitTest to View::HitTestRect

chrome/browser/ui/views/location_bar/content_setting_image_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/location_bar/content_setting_image_view.h"
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
 #include "chrome/browser/ui/content_settings/content_setting_bubble_model.h"
 #include "chrome/browser/ui/content_settings/content_setting_image_model.h"
@@ skipping 147 matching lines @@
   AnimationEnded(animation);
 }
 
 bool ContentSettingImageView::OnMousePressed(const views::MouseEvent& event) {
   // We want to show the bubble on mouse release; that is the standard behavior
   // for buttons.
   return true;
 }
 
 void ContentSettingImageView::OnMouseReleased(const views::MouseEvent& event) {
-  if (!HitTest(event.location()))
+  if (!HitTest(gfx::Rect(event.location(), gfx::Size(0, 0))))

[sky, 2012/08/07 20:11:43]

Based on how many calls of this we have I think its worth adding two:

bool HitTestPoint(const gfx::Point& point) {
  return HitTestRect(gfx::Rect(point, whatever size you decide);
}

The key thing is the first is non-virtual.

virtual bool HitRectRect(...);

[tdanderson, 2012/08/08 23:47:51]

Done.

     return;
 
   TabContents* tab_contents = parent_->GetTabContents();
   if (!tab_contents)
     return;
 
   // Stop animation.
   if (slide_animator_.get() && slide_animator_->is_animating()) {
     slide_animator_->Reset();
     pause_animation_ = true;
@@ skipping 84 matching lines @@
         1.0 - (visible_text_size_ * kAnimatingFraction) / text_size_);
     pause_animation_ = false;
     slide_animator_->Show();
   }
 }
 
 int ContentSettingImageView::GetBuiltInHorizontalPadding() const {
   return GetBuiltInHorizontalPaddingImpl();
 }