Change View::HitTest to View::HitTestRect

chrome/browser/ui/views/frame/opaque_browser_frame_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/opaque_browser_frame_view.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/command_line.h"
@@ skipping 379 matching lines @@
     PaintRestoredClientEdge(canvas);
 }
 
 void OpaqueBrowserFrameView::Layout() {
   LayoutWindowControls();
   LayoutTitleBar();
   LayoutAvatar();
   client_view_bounds_ = CalculateClientAreaBounds(width(), height());
 }
 
-bool OpaqueBrowserFrameView::HitTest(const gfx::Point& l) const {
+bool OpaqueBrowserFrameView::HitTest(const gfx::Rect& r) const {
   // If the point is outside the bounds of the client area, claim it.
-  bool in_nonclient = NonClientFrameView::HitTest(l);
+  bool in_nonclient = NonClientFrameView::HitTest(r);
   if (in_nonclient)
     return in_nonclient;
 
   // Otherwise claim it only if it's in a non-tab portion of the tabstrip.
   if (!browser_view()->tabstrip())
     return false;
   gfx::Rect tabstrip_bounds(browser_view()->tabstrip()->bounds());
   gfx::Point tabstrip_origin(tabstrip_bounds.origin());
   View::ConvertPointToView(frame()->client_view(), this, &tabstrip_origin);
   tabstrip_bounds.set_origin(tabstrip_origin);
-  if (l.y() > tabstrip_bounds.bottom())
+  if (r.y() > tabstrip_bounds.bottom())

[tdanderson, 2012/08/07 16:18:28]

Should this instead be r.y() + r.height() ?

[sky, 2012/08/07 20:11:43]

Same comments in this file as the ash file.

[tdanderson, 2012/08/08 23:47:51]

Done.

     return false;
 
   // We convert from our parent's coordinates since we assume we fill its bounds
   // completely. We need to do this since we're not a parent of the tabstrip,
   // meaning ConvertPointToView would otherwise return something bogus.
-  gfx::Point browser_view_point(l);
+  gfx::Point browser_view_point(gfx::Point(r.x(), r.y()));

[tdanderson, 2012/08/08 23:47:51]

I am also passing through the center point here for the same reasons as in the
ash file. Please let me know if you feel this is acceptable.

[tdanderson, 2012/08/09 16:16:46]

Also added a TODO here as well.

   View::ConvertPointToView(parent(), browser_view(), &browser_view_point);
   return browser_view()->IsPositionInWindowCaption(browser_view_point);
 }
 
 void OpaqueBrowserFrameView::GetAccessibleState(
     ui::AccessibleViewState* state) {
   state->role = ui::AccessibilityTypes::ROLE_TITLEBAR;
 }
 
 ///////////////////////////////////////////////////////////////////////////////
@@ skipping 601 matching lines @@
 
 gfx::Rect OpaqueBrowserFrameView::CalculateClientAreaBounds(int width,
                                                             int height) const {
   int top_height = NonClientTopBorderHeight(false);
   int border_thickness = NonClientBorderThickness();
   return gfx::Rect(border_thickness, top_height,
                    std::max(0, width - (2 * border_thickness)),
                    std::max(0, height - GetReservedHeight() -
                        top_height - border_thickness));
 }