samples/sample_extension/sample_extension.gypi - Issue 10827197: Add samples gyp target to Dart project, that builds samples/sample_extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/sample_extension/sample_extension.gypi

Issue 10827197: Add samples gyp target to Dart project, that builds samples/sample_extension. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix copyright date. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: samples/sample_extension/sample_extension.gypi

diff --git a/samples/sample_extension/sample_extension.gypi b/samples/sample_extension/sample_extension.gypi

index 947bc0d2d85ab11b4474033ebd69a3099c73e66e..a636cbe173913e36379a8d7c84fa4e1d023be211 100644

--- a/samples/sample_extension/sample_extension.gypi

+++ b/samples/sample_extension/sample_extension.gypi

@@ -8,7 +8,7 @@

'target_name': 'sample_extension',

'type': 'shared_library',

'dependencies': [

- 'dart',

+ '../runtime/dart-runtime.gyp:dart',

'include_dirs': [

'../../runtime/include',

Bill Hesse 2012/08/07 10:24:55 I checked, and this needs to be ../../runtime, and

ahe 2012/08/07 11:42:31 The problem is that you didn't put the gyp file in

Bill Hesse 2012/08/07 12:23:19 Fixed. This is now a gyp file. On 2012/08/07 11:

« dart.gyp ('K') | « dart.gyp ('k') | samples/samples.gyp » ('j') | no next file with comments »