chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc - Issue 10827191: Convert extension action icons code to use ImageSkia instead of SkBitmap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

Issue 10827191: Convert extension action icons code to use ImageSkia instead of SkBitmap (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/page_action_image_view.cc ('k') | chrome/common/extensions/extension_action.h » ('j') | chrome/common/extensions/extension_action.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

diff --git a/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc b/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

index a57e64accd520bac629f04814cf0e75ac2217482..33e37c7750a9fc6282a9bb46ce9255ba0fa32dfc 100644

--- a/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

+++ b/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc

@@ -36,7 +36,7 @@ void PageActionWithBadgeView::Layout() {

// sized icons (such as 16x16) have either a 5 or a 4 pixel whitespace

// (padding) above and below. It looks better to have the extra pixel above

// the icon than below it, so we add a pixel. http://crbug.com/25708.

- const SkBitmap& image = image_view()->GetImage();

+ const gfx::ImageSkia& image = image_view()->GetImage();

int y = (image.height() + 1) % 2; // Even numbers: 1px padding. Odd: 0px.

image_view_->SetBounds(0, y, width(), height());

}