Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1475)

Side by Side Diff: chrome/common/extensions/extension.cc

Issue 10827191: Convert extension action icons code to use ImageSkia instead of SkBitmap (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove includes we don't need anymore Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension.h" 5 #include "chrome/common/extensions/extension.h"
6 6
7 #include <ostream> 7 #include <ostream>
8 8
9 #include "base/base64.h" 9 #include "base/base64.h"
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 2360 matching lines...) Expand 10 before | Expand all | Expand 10 after
2371 InstallWarning(InstallWarning::FORMAT_TEXT, 2371 InstallWarning(InstallWarning::FORMAT_TEXT,
2372 errors::kScriptBadgeIconIgnored)); 2372 errors::kScriptBadgeIconIgnored));
2373 } 2373 }
2374 std::string icon16_path = icons().Get(ExtensionIconSet::EXTENSION_ICON_BITTY, 2374 std::string icon16_path = icons().Get(ExtensionIconSet::EXTENSION_ICON_BITTY,
2375 ExtensionIconSet::MATCH_EXACTLY); 2375 ExtensionIconSet::MATCH_EXACTLY);
2376 if (!icon16_path.empty()) { 2376 if (!icon16_path.empty()) {
2377 script_badge_->set_default_icon_path(icon16_path); 2377 script_badge_->set_default_icon_path(icon16_path);
2378 } else { 2378 } else {
2379 script_badge_->SetIcon( 2379 script_badge_->SetIcon(
2380 ExtensionAction::kDefaultTabId, 2380 ExtensionAction::kDefaultTabId,
2381 *ui::ResourceBundle::GetSharedInstance().GetImageNamed( 2381 ui::ResourceBundle::GetSharedInstance().GetImageNamed(
2382 IDR_EXTENSIONS_FAVICON).ToSkBitmap()); 2382 IDR_EXTENSIONS_FAVICON));
2383 } 2383 }
2384 2384
2385 return true; 2385 return true;
2386 } 2386 }
2387 2387
2388 bool Extension::LoadFileBrowserHandlers(string16* error) { 2388 bool Extension::LoadFileBrowserHandlers(string16* error) {
2389 if (!manifest_->HasKey(keys::kFileBrowserHandlers)) 2389 if (!manifest_->HasKey(keys::kFileBrowserHandlers))
2390 return true; 2390 return true;
2391 ListValue* file_browser_handlers_value = NULL; 2391 ListValue* file_browser_handlers_value = NULL;
2392 if (!manifest_->GetList(keys::kFileBrowserHandlers, 2392 if (!manifest_->GetList(keys::kFileBrowserHandlers,
(...skipping 1508 matching lines...) Expand 10 before | Expand all | Expand 10 after
3901 3901
3902 UpdatedExtensionPermissionsInfo::UpdatedExtensionPermissionsInfo( 3902 UpdatedExtensionPermissionsInfo::UpdatedExtensionPermissionsInfo(
3903 const Extension* extension, 3903 const Extension* extension,
3904 const PermissionSet* permissions, 3904 const PermissionSet* permissions,
3905 Reason reason) 3905 Reason reason)
3906 : reason(reason), 3906 : reason(reason),
3907 extension(extension), 3907 extension(extension),
3908 permissions(permissions) {} 3908 permissions(permissions) {}
3909 3909
3910 } // namespace extensions 3910 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698