Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: chrome/browser/extensions/api/extension_action/page_action_apitest.cc

Issue 10827191: Convert extension action icons code to use ImageSkia instead of SkBitmap (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/browser_event_router.h" 5 #include "chrome/browser/extensions/browser_event_router.h"
6 #include "chrome/browser/extensions/extension_apitest.h" 6 #include "chrome/browser/extensions/extension_apitest.h"
7 #include "chrome/browser/extensions/extension_service.h" 7 #include "chrome/browser/extensions/extension_service.h"
8 #include "chrome/browser/extensions/extension_tab_util.h" 8 #include "chrome/browser/extensions/extension_tab_util.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/sessions/restore_tab_helper.h" 10 #include "chrome/browser/sessions/restore_tab_helper.h"
11 #include "chrome/browser/ui/browser.h" 11 #include "chrome/browser/ui/browser.h"
12 #include "chrome/browser/ui/browser_tabstrip.h" 12 #include "chrome/browser/ui/browser_tabstrip.h"
13 #include "chrome/browser/ui/browser_window.h" 13 #include "chrome/browser/ui/browser_window.h"
14 #include "chrome/browser/ui/omnibox/location_bar.h" 14 #include "chrome/browser/ui/omnibox/location_bar.h"
15 #include "chrome/browser/ui/tab_contents/tab_contents.h" 15 #include "chrome/browser/ui/tab_contents/tab_contents.h"
16 #include "chrome/common/extensions/extension.h" 16 #include "chrome/common/extensions/extension.h"
17 #include "chrome/common/extensions/extension_action.h" 17 #include "chrome/common/extensions/extension_action.h"
18 #include "chrome/test/base/ui_test_utils.h" 18 #include "chrome/test/base/ui_test_utils.h"
19 #include "content/public/browser/web_contents.h" 19 #include "content/public/browser/web_contents.h"
20 #include "ui/gfx/image/image_skia.h"
20 21
21 using extensions::Extension; 22 using extensions::Extension;
22 23
23 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, PageAction) { 24 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, PageAction) {
24 ASSERT_TRUE(test_server()->Start()); 25 ASSERT_TRUE(test_server()->Start());
25 ASSERT_TRUE(RunExtensionTest("page_action/basics")) << message_; 26 ASSERT_TRUE(RunExtensionTest("page_action/basics")) << message_;
26 const Extension* extension = GetSingleLoadedExtension(); 27 const Extension* extension = GetSingleLoadedExtension();
27 ASSERT_TRUE(extension) << message_; 28 ASSERT_TRUE(extension) << message_;
28 { 29 {
29 // Tell the extension to update the page action state. 30 // Tell the extension to update the page action state.
(...skipping 25 matching lines...) Expand all
55 // Tell the extension to update the page action state again. 56 // Tell the extension to update the page action state again.
56 ResultCatcher catcher; 57 ResultCatcher catcher;
57 ui_test_utils::NavigateToURL(browser(), 58 ui_test_utils::NavigateToURL(browser(),
58 GURL(extension->GetResourceURL("update2.html"))); 59 GURL(extension->GetResourceURL("update2.html")));
59 ASSERT_TRUE(catcher.GetNextResult()); 60 ASSERT_TRUE(catcher.GetNextResult());
60 } 61 }
61 62
62 // Test that we received the changes. 63 // Test that we received the changes.
63 tab_id = chrome::GetActiveTabContents(browser())->restore_tab_helper()-> 64 tab_id = chrome::GetActiveTabContents(browser())->restore_tab_helper()->
64 session_id().id(); 65 session_id().id();
65 EXPECT_FALSE(action->GetIcon(tab_id).IsEmpty()); 66 EXPECT_FALSE(action->GetIcon(tab_id).empty());
66 } 67 }
67 68
68 // Test that calling chrome.pageAction.setPopup() can enable a popup. 69 // Test that calling chrome.pageAction.setPopup() can enable a popup.
69 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, PageActionAddPopup) { 70 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, PageActionAddPopup) {
70 // Load the extension, which has no default popup. 71 // Load the extension, which has no default popup.
71 ASSERT_TRUE(RunExtensionTest("page_action/add_popup")) << message_; 72 ASSERT_TRUE(RunExtensionTest("page_action/add_popup")) << message_;
72 const Extension* extension = GetSingleLoadedExtension(); 73 const Extension* extension = GetSingleLoadedExtension();
73 ASSERT_TRUE(extension) << message_; 74 ASSERT_TRUE(extension) << message_;
74 75
75 int tab_id = ExtensionTabUtil::GetTabId( 76 int tab_id = ExtensionTabUtil::GetTabId(
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, Getters) { 204 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, Getters) {
204 ASSERT_TRUE(RunExtensionTest("page_action/getters")) << message_; 205 ASSERT_TRUE(RunExtensionTest("page_action/getters")) << message_;
205 const Extension* extension = GetSingleLoadedExtension(); 206 const Extension* extension = GetSingleLoadedExtension();
206 ASSERT_TRUE(extension) << message_; 207 ASSERT_TRUE(extension) << message_;
207 208
208 ResultCatcher catcher; 209 ResultCatcher catcher;
209 ui_test_utils::NavigateToURL(browser(), 210 ui_test_utils::NavigateToURL(browser(),
210 GURL(extension->GetResourceURL("update.html"))); 211 GURL(extension->GetResourceURL("update.html")));
211 ASSERT_TRUE(catcher.GetNextResult()); 212 ASSERT_TRUE(catcher.GetNextResult());
212 } 213 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698