Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 10827189: SafeBrowsingSystemTest: use notification for end of update instead of polling. (Closed)

Created:
8 years, 4 months ago by mattm
Modified:
8 years, 4 months ago
Reviewers:
Brian Ryner
CC:
chromium-reviews
Visibility:
Public.

Description

SafeBrowsingSystemTest: use notification for end of update instead of polling. BUG=96459 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150970

Patch Set 1 #

Patch Set 2 : re-disable the test #

Total comments: 2

Patch Set 3 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -36 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_test.cc View 1 2 6 chunks +23 lines, -36 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mattm
8 years, 4 months ago (2012-08-08 21:32:34 UTC) #1
Brian Ryner
lgtm http://codereview.chromium.org/10827189/diff/7001/chrome/browser/safe_browsing/safe_browsing_test.cc File chrome/browser/safe_browsing/safe_browsing_test.cc (right): http://codereview.chromium.org/10827189/diff/7001/chrome/browser/safe_browsing/safe_browsing_test.cc#newcode440 chrome/browser/safe_browsing/safe_browsing_test.cc:440: // Wait for a given period to get ...
8 years, 4 months ago (2012-08-09 18:10:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mattm@chromium.org/10827189/4004
8 years, 4 months ago (2012-08-10 00:12:51 UTC) #3
mattm
http://codereview.chromium.org/10827189/diff/7001/chrome/browser/safe_browsing/safe_browsing_test.cc File chrome/browser/safe_browsing/safe_browsing_test.cc (right): http://codereview.chromium.org/10827189/diff/7001/chrome/browser/safe_browsing/safe_browsing_test.cc#newcode440 chrome/browser/safe_browsing/safe_browsing_test.cc:440: // Wait for a given period to get safebrowsing ...
8 years, 4 months ago (2012-08-10 00:12:53 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-10 01:51:07 UTC) #5
Change committed as 150970

Powered by Google App Engine
This is Rietveld 408576698