Issue 10827184: Disabling extended desktop (by default).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827184: Disabling extended desktop (by default). (Closed)

Created:
8 years, 4 months ago by Emmanuel Saint-loubert-Bié

Modified:
8 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org, Daniel Erat, oshima

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

This is a verbatim revert of https://chromiumcodereview.appspot.com/10800095/ (except for file ash/accelerators/accelerator_table.cc which was an unrelated fix) BUG=140822 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150161

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebased. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -27 lines)			Patch
M	ash/ash_switches.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ash/ash_switches.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ash/display/display_controller.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ash/display/display_controller.cc	View	1 2	2 chunks	+11 lines, -3 lines	0 comments	Download
M	ash/display/display_controller_unittest.cc	View		1 chunk	+18 lines, -1 line	0 comments	Download
M	ash/display/multi_display_manager_unittest.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	ash/extended_desktop_unittest.cc	View	1 2	3 chunks	+27 lines, -9 lines	0 comments	Download
M	ash/root_window_controller_unittest.cc	View		1 chunk	+17 lines, -1 line	0 comments	Download
M	ash/screen_ash_unittest.cc	View		1 chunk	+17 lines, -1 line	0 comments	Download
M	ash/wm/window_cycle_controller_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/app/generated_resources.grd	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emmanuel Saint-loubert-Bié

Hi Scott, It was decided to revert the default before branching 22. -- Emmanuel

8 years, 4 months ago (2012-08-06 19:53:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/10827184/11013

8 years, 4 months ago (2012-08-06 21:59:30 UTC) #3

commit-bot: I haz the power

8 years, 4 months ago (2012-08-06 22:38:07 UTC) #4

Try job failure for 10827184-11013 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

Expand Messages | Collapse Messages