Don't show the translate bar when refreshing a page with the notranslate content tag.

Don't show the translate bar when refreshing a page with the notranslate content tag.

BUG=112732
TEST=Make sure that we never show the translate bar for pages that have the notranslate content tag.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150263

[robertshield, 2012-08-06 19:19:56]

lgtm

[commit-bot: I haz the power, 2012-08-07 00:14:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mad@chromium.org/10827183/1

[commit-bot: I haz the power, 2012-08-07 00:14:33]

Presubmit check for 10827183-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[MAD, 2012-08-07 00:45:26]

We now need src\chrome\OWNERS review for code under the browser\translate
sub-module... 

So I have another CL to add me as the owner...

Let me know if you prefer I ask another of the chrome\OWNERS...

Thanks!

BYE
MAD...

[James Hawkins, 2012-08-07 00:49:13]

LGTM

https://chromiumcodereview.appspot.com/10827183/diff/1/chrome/browser/transla...
File chrome/browser/translate/translate_manager.cc (right):

https://chromiumcodereview.appspot.com/10827183/diff/1/chrome/browser/transla...
chrome/browser/translate/translate_manager.cc:337: // When doing a page reload,
we don't get a TAB_LANGUAGE_DETERMINED
Drive-by optional nit: Don't use pronouns (we) in comments; pronouns are
ambiguous.

https://chromiumcodereview.appspot.com/10827183/diff/1/chrome/browser/transla...
chrome/browser/translate/translate_manager.cc:339: // At least when the page is
indeed translatable.
Grammar nit: Sentence fragment.

[MAD, 2012-08-07 01:25:04]

Thanks!

https://chromiumcodereview.appspot.com/10827183/diff/1/chrome/browser/transla...
File chrome/browser/translate/translate_manager.cc (right):

https://chromiumcodereview.appspot.com/10827183/diff/1/chrome/browser/transla...
chrome/browser/translate/translate_manager.cc:337: // When doing a page reload,
we don't get a TAB_LANGUAGE_DETERMINED
On 2012/08/07 00:49:13, James Hawkins wrote:
> Drive-by optional nit: Don't use pronouns (we) in comments; pronouns are
> ambiguous.

Done.

https://chromiumcodereview.appspot.com/10827183/diff/1/chrome/browser/transla...
chrome/browser/translate/translate_manager.cc:339: // At least when the page is
indeed translatable.
On 2012/08/07 00:49:13, James Hawkins wrote:
> Grammar nit: Sentence fragment.

Done.

[commit-bot: I haz the power, 2012-08-07 01:25:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mad@chromium.org/10827183/7002

[commit-bot: I haz the power, 2012-08-07 04:04:14]

Change committed as 150263