Issue 10827182: Rename layoutTestController to testRunner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827182: Rename layoutTestController to testRunner. (Closed)

Created:
8 years, 4 months ago by jochen (gone - plz use gerrit)

Modified:
8 years, 4 months ago

Reviewers:
rniwa-cr, darin (slow to review)

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, pam+watch_chromium.org, michaeln, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Rename layoutTestController to testRunner. I should come up with a better name than LayoutTestController{Host,} for content_shell The extension docs are updated here: https://chromiumcodereview.appspot.com/10825200/ The binaries in chrome/test/data/extensions/uitest don't actually invoke LTC BUG=none TEST=still works after WK roll Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150320

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -21 lines)			Patch
M	chrome/tools/test/generate_mime_tests.pl	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/appcache/appcache_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/shell/layout_test_controller.js	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	content/shell/layout_test_controller_host.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/shell/shell_messages.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/test/layout_browsertest.cc	View		2 chunks	+5 lines, -6 lines	0 comments	Download
M	webkit/glue/webkit_glue.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/support/simple_database_system.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/notification_presenter.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

darin (slow to review)

LGTM I really hope we can eliminate references to testRunner from the Chromium repository!

8 years, 4 months ago (2012-08-06 22:43:01 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10827182/2002

8 years, 4 months ago (2012-08-07 09:15:08 UTC) #3

Change committed as 150320