Issue 10827177: Change the screenshot file format not to use colons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827177: Change the screenshot file format not to use colons. (Closed)

Created:
8 years, 4 months ago by Jun Mukai

Modified:
8 years, 4 months ago

Reviewers:
Daniel Erat, Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Change the screenshot file format not to use colons. As is suggested in crbug.com/133956 comment #5, - add " at " between date and time - use dot instead of colon for time, since colon is not allowed for HFS+/FAT32 BUG=133956, 140355 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150216

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/browser/ui/ash/screenshot_taker.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/10827177/1

8 years, 4 months ago (2012-08-07 00:01:15 UTC) #4

Change committed as 150216

Expand Messages | Collapse Messages