Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 10827174: Fix backwards use of EXPECT_OP in test. (Closed)

Created:
8 years, 4 months ago by grt (UTC plus 2)
Modified:
8 years, 4 months ago
Reviewers:
gab
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Fix backwards use of EXPECT_OP in test. BUG=none TEST=none TBR=gab@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150340

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/installer/util/product_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
grt (UTC plus 2)
Cleanup from review in https://chromiumcodereview.appspot.com/10826144/. Thanks for the thorough review, Gab.
8 years, 4 months ago (2012-08-04 19:19:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/10827174/1
8 years, 4 months ago (2012-08-04 19:20:03 UTC) #2
commit-bot: I haz the power
Try job failure for 10827174-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-04 19:37:37 UTC) #3
gab
lgtm (there was also the return void for DeleteLocalState IIRC).
8 years, 4 months ago (2012-08-04 19:39:29 UTC) #4
grt (UTC plus 2)
On 2012/08/04 19:39:29, gab wrote: > lgtm (there was also the return void for DeleteLocalState ...
8 years, 4 months ago (2012-08-04 19:40:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/10827174/1
8 years, 4 months ago (2012-08-07 12:29:33 UTC) #6
gab
On 2012/08/04 19:40:57, grt wrote: > On 2012/08/04 19:39:29, gab wrote: > > lgtm (there ...
8 years, 4 months ago (2012-08-07 12:29:51 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 14:04:54 UTC) #8
Change committed as 150340

Powered by Google App Engine
This is Rietveld 408576698