Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 10827161: Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS. (Closed)

Created:
8 years, 4 months ago by rpetterson
Modified:
8 years, 4 months ago
CC:
chromium-reviews, ncarter (slow), mihaip-chromium-reviews_chromium.org, akalin, Raghu Simha, Aaron Boodman, tim (not reviewing), sky
Visibility:
Public.

Description

Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS. BUG=112525 TBR=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150160

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M chrome/browser/bookmarks/bookmark_extension_api.cc View 8 chunks +19 lines, -14 lines 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
rpetterson
atwilson - sync/integration sky - TBR'd for bookmarks
8 years, 4 months ago (2012-08-03 20:29:13 UTC) #1
rpetterson
Making sure sky@ sees it.
8 years, 4 months ago (2012-08-03 20:30:48 UTC) #2
sky
SLGTM
8 years, 4 months ago (2012-08-03 22:31:18 UTC) #3
Andrew T Wilson (Slow)
LGTM
8 years, 4 months ago (2012-08-06 17:52:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/10827161/1
8 years, 4 months ago (2012-08-06 18:06:27 UTC) #5
commit-bot: I haz the power
Try job failure for 10827161-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-06 18:26:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/10827161/1
8 years, 4 months ago (2012-08-06 18:49:36 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-06 22:52:09 UTC) #8
Change committed as 150160

Powered by Google App Engine
This is Rietveld 408576698