Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4339)

Unified Diff: chrome/common/extensions/extension_action_unittest.cc

Issue 10827158: Fix leaks in tests introduced in http://crrev.com/149846. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_action_unittest.cc
diff --git a/chrome/common/extensions/extension_action_unittest.cc b/chrome/common/extensions/extension_action_unittest.cc
index f6ea46f4788ada7512bbcfdbe0fef55ea5743643..9cf8ed86ca31ca426e7f507b504d62df7dc91fc7 100644
--- a/chrome/common/extensions/extension_action_unittest.cc
+++ b/chrome/common/extensions/extension_action_unittest.cc
@@ -137,6 +137,8 @@ TEST_F(ExtensionActionTest, Visibility) {
ASSERT_FALSE(action.GetIsVisible(1));
ASSERT_FALSE(action.GetIsVisible(100));
EXPECT_FALSE(action.GetIconAnimation(100));
+
+ message_loop.RunAllPending();
}
TEST_F(ExtensionActionTest, GetAttention) {
@@ -156,6 +158,8 @@ TEST_F(ExtensionActionTest, GetAttention) {
action.SetAppearance(1, ExtensionAction::ACTIVE);
EXPECT_FALSE(action.GetIconAnimation(1))
<< "The animation should not play again if the icon was already visible.";
+
+ message_loop.RunAllPending();
}
TEST_F(ExtensionActionTest, Badge) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698