Issue 10827157: Remove ScopedAllowIO from MediaPathFilter

Issue 10827157: Remove ScopedAllowIO from MediaPathFilter (Closed)

Created:
8 years, 4 months ago by tzik

Modified:
8 years, 4 months ago

Reviewers:
kinuko

CC:
chromium-reviews, feature-media-reviews_chromium.org, kinuko+watch, darin-cc_chromium.org, Mihai Parparita -not on Chrome

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove ScopedAllowIO from MediaPathFilter BUG=140401 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149948

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -14 lines)			Patch
	M	webkit/fileapi/media/media_path_filter.h	View		2 chunks	+6 lines, -1 line	0 comments	Download
	M	webkit/fileapi/media/media_path_filter.cc	View		3 chunks	+22 lines, -13 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tzik

I'm trying to get rid of ScopedAllowIO that I put yesterday. Could you take a ...

8 years, 4 months ago (2012-08-03 16:04:32 UTC) #1

kinuko

http://codereview.chromium.org/10827157/diff/1/webkit/fileapi/media/media_path_filter.cc File webkit/fileapi/media/media_path_filter.cc (right): http://codereview.chromium.org/10827157/diff/1/webkit/fileapi/media/media_path_filter.cc#newcode43 webkit/fileapi/media/media_path_filter.cc:43: base::AutoLock lock(initialization_lock_); qq: does this need a lock?

8 years, 4 months ago (2012-08-03 20:58:57 UTC) #2

tzik

8 years, 4 months ago (2012-08-03 21:24:02 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/10827157/1

8 years, 4 months ago (2012-08-03 21:24:21 UTC) #5

Change committed as 149948

Expand Messages | Collapse Messages