Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 10827149: Check VideoFrame::IsValidConfig() prior to allocating buffers for FFmpeg. (Closed)

Created:
8 years, 4 months ago by scherkus (not reviewing)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Check VideoFrame::IsValidConfig() prior to allocating buffers for FFmpeg. BUG=140085 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150215

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M media/filters/ffmpeg_video_decoder.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scherkus (not reviewing)
rbultje: sanity check fischman: OWNERS + review https://chromiumcodereview.appspot.com/10827149/diff/1/media/filters/ffmpeg_video_decoder.cc File media/filters/ffmpeg_video_decoder.cc (right): https://chromiumcodereview.appspot.com/10827149/diff/1/media/filters/ffmpeg_video_decoder.cc#newcode88 media/filters/ffmpeg_video_decoder.cc:88: VideoFrame::CreateFrame(format, width, ...
8 years, 4 months ago (2012-08-06 20:42:34 UTC) #1
Ami GONE FROM CHROMIUM
lgtm
8 years, 4 months ago (2012-08-06 21:14:19 UTC) #2
rbultje1
lgtm also.
8 years, 4 months ago (2012-08-06 21:24:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/10827149/1
8 years, 4 months ago (2012-08-06 22:16:05 UTC) #4
commit-bot: I haz the power
Try job failure for 10827149-1 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-06 22:42:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/10827149/9003
8 years, 4 months ago (2012-08-06 23:31:41 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 01:21:32 UTC) #7
Change committed as 150215

Powered by Google App Engine
This is Rietveld 408576698