Add a switch for enabling the WebsiteSettingsUI to the about:flags page.

Add switch for enabling the WebsiteSettingsUI to the about:flags page.


BUG=113688
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150401

[markusheintz_, 2012-08-02 19:44:11]

Could you review this CL please? Thanks a lot!

[Bernhard Bauer, 2012-08-02 19:46:28]

LGTM w/ nits:

https://chromiumcodereview.appspot.com/10827142/diff/1/chrome/app/generated_r...
File chrome/app/generated_resources.grd (right):

https://chromiumcodereview.appspot.com/10827142/diff/1/chrome/app/generated_r...
chrome/app/generated_resources.grd:5688: +        Enables the Website Settings
UI. The Website Settings UI replaces the PageInfoBubble and provides an easy way
to configure site specific settings.
Nit: PageInfoBubble in CamelCase is a class name, the user-visible term is
probably just "page info bubble".

Also: "site-specific".

[markusheintz_, 2012-08-02 19:50:47]

Thanks a lot!

https://chromiumcodereview.appspot.com/10827142/diff/1/chrome/app/generated_r...
File chrome/app/generated_resources.grd (right):

https://chromiumcodereview.appspot.com/10827142/diff/1/chrome/app/generated_r...
chrome/app/generated_resources.grd:5688: +        Enables the Website Settings
UI. The Website Settings UI replaces the PageInfoBubble and provides an easy way
to configure site specific settings.
On 2012/08/02 19:46:28, Bernhard Bauer wrote:
> Nit: PageInfoBubble in CamelCase is a class name, the user-visible term is
> probably just "page info bubble".
> 
> Also: "site-specific".

Done.

[Bernhard Bauer, 2012-08-02 19:51:32]

https://chromiumcodereview.appspot.com/10827142/diff/1/chrome/app/generated_r...
File chrome/app/generated_resources.grd (right):

https://chromiumcodereview.appspot.com/10827142/diff/1/chrome/app/generated_r...
chrome/app/generated_resources.grd:5688: +        Enables the Website Settings
UI. The Website Settings UI replaces the PageInfoBubble and provides an easy way
to configure site specific settings.
On 2012/08/02 19:50:47, markusheintz_ wrote:
> On 2012/08/02 19:46:28, Bernhard Bauer wrote:
> > Nit: PageInfoBubble in CamelCase is a class name, the user-visible term is
> > probably just "page info bubble".
> > 
> > Also: "site-specific".
> 
> Done.

LIES

[Bernhard Bauer, 2012-08-02 19:52:05]

https://chromiumcodereview.appspot.com/10827142/diff/1/chrome/app/generated_r...
File chrome/app/generated_resources.grd (right):

https://chromiumcodereview.appspot.com/10827142/diff/1/chrome/app/generated_r...
chrome/app/generated_resources.grd:5688: +        Enables the Website Settings
UI. The Website Settings UI replaces the PageInfoBubble and provides an easy way
to configure site specific settings.
On 2012/08/02 19:51:32, Bernhard Bauer wrote:
> On 2012/08/02 19:50:47, markusheintz_ wrote:
> > On 2012/08/02 19:46:28, Bernhard Bauer wrote:
> > > Nit: PageInfoBubble in CamelCase is a class name, the user-visible term is
> > > probably just "page info bubble".
> > > 
> > > Also: "site-specific".
> > 
> > Done.
> 
> LIES

Oh, I take it back. Rietveld sucks (or I suck at Rietveld).

[markusheintz_, 2012-08-02 19:58:08]

On 2012/08/02 19:52:05, Bernhard Bauer wrote:
>
https://chromiumcodereview.appspot.com/10827142/diff/1/chrome/app/generated_r...
> File chrome/app/generated_resources.grd (right):
> 
>
https://chromiumcodereview.appspot.com/10827142/diff/1/chrome/app/generated_r...
> chrome/app/generated_resources.grd:5688: +        Enables the Website Settings
> UI. The Website Settings UI replaces the PageInfoBubble and provides an easy
way
> to configure site specific settings.
> On 2012/08/02 19:51:32, Bernhard Bauer wrote:
> > On 2012/08/02 19:50:47, markusheintz_ wrote:
> > > On 2012/08/02 19:46:28, Bernhard Bauer wrote:
> > > > Nit: PageInfoBubble in CamelCase is a class name, the user-visible term
is
> > > > probably just "page info bubble".
> > > > 
> > > > Also: "site-specific".
> > > 
> > > Done.
> > 
> > LIES
> 
> Oh, I take it back. Rietveld sucks (or I suck at Rietveld).

I would never dare to lie to you  :-).

[Bernhard Bauer, 2012-08-02 20:00:22]

On 2012/08/02 19:58:08, markusheintz_ wrote:
> On 2012/08/02 19:52:05, Bernhard Bauer wrote:
> >
>
https://chromiumcodereview.appspot.com/10827142/diff/1/chrome/app/generated_r...
> > File chrome/app/generated_resources.grd (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/10827142/diff/1/chrome/app/generated_r...
> > chrome/app/generated_resources.grd:5688: +        Enables the Website
Settings
> > UI. The Website Settings UI replaces the PageInfoBubble and provides an easy
> way
> > to configure site specific settings.
> > On 2012/08/02 19:51:32, Bernhard Bauer wrote:
> > > On 2012/08/02 19:50:47, markusheintz_ wrote:
> > > > On 2012/08/02 19:46:28, Bernhard Bauer wrote:
> > > > > Nit: PageInfoBubble in CamelCase is a class name, the user-visible
term
> is
> > > > > probably just "page info bubble".
> > > > > 
> > > > > Also: "site-specific".
> > > > 
> > > > Done.
> > > 
> > > LIES
> > 
> > Oh, I take it back. Rietveld sucks (or I suck at Rietveld).
> 
> I would never dare to lie to you  :-).

Or that's a lie as well. Circular reasoning FTW!

[commit-bot: I haz the power, 2012-08-07 13:31:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10827142/5006

[commit-bot: I haz the power, 2012-08-07 13:31:30]

Presubmit check for 10827142-5006 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Presubmit checks took 1.3s to calculate.

[markusheintz_, 2012-08-07 13:43:25]

Adding Ben for owners approval.

@Ben: Please review this CL. Thanks

[Ben Goodger (Google), 2012-08-07 18:17:23]

lgtm

[commit-bot: I haz the power, 2012-08-07 18:21:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10827142/5006

[commit-bot: I haz the power, 2012-08-07 21:07:46]

Change committed as 150401