Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/browser/resources/options/settings_dialog.js

Issue 10827141: Move handling of dialog preferences to Preferences class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed PrefCheckbox. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/settings_dialog.js
diff --git a/chrome/browser/resources/options/settings_dialog.js b/chrome/browser/resources/options/settings_dialog.js
index 609bbaaa9df11e63cff4d9263149850f167d7b2b..5401fcfe09797b5951371c224b2005e3b2a85e2d 100644
--- a/chrome/browser/resources/options/settings_dialog.js
+++ b/chrome/browser/resources/options/settings_dialog.js
@@ -43,10 +43,11 @@ cr.define('options', function() {
handleConfirm: function() {
OptionsPage.closeOverlay();
+ var prefs = Preferences.getInstance();
var els = this.pageDiv.querySelectorAll('[dialog-pref]');
for (var i = 0; i < els.length; i++) {
- if (els[i].savePrefState)
- els[i].savePrefState();
+ if (els[i].pref)
+ prefs.commitPref(els[i].pref, els[i].metric);
}
},
@@ -56,10 +57,11 @@ cr.define('options', function() {
handleCancel: function() {
OptionsPage.closeOverlay();
+ var prefs = Preferences.getInstance();
var els = this.pageDiv.querySelectorAll('[dialog-pref]');
for (var i = 0; i < els.length; i++) {
- if (els[i].resetPrefState)
- els[i].resetPrefState();
+ if (els[i].pref)
+ prefs.rollbackPref(els[i].pref);
}
},
};
« no previous file with comments | « chrome/browser/resources/options/preferences.js ('k') | chrome/browser/resources/options/spelling_confirm_overlay.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698