Move handling of dialog preferences to Preferences class

chrome/browser/resources/options/font_settings.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
 
   var OptionsPage = options.OptionsPage;
 
   /**
    * FontSettings class
@@ skipping 14 matching lines @@
 
     /**
      * Initialize the page.
      */
     initializePage: function() {
       OptionsPage.prototype.initializePage.call(this);
 
       var standardFontRange = $('standard-font-size');
       standardFontRange.valueMap = [9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 20,
           22, 24, 26, 28, 30, 32, 34, 36, 40, 44, 48, 56, 64, 72];
-      standardFontRange.continuous = false;
-      standardFontRange.notifyChange = this.standardRangeChanged_.bind(this);
-      standardFontRange.notifyPrefChange =
-          this.standardFontSizeChanged_.bind(this);
+      standardFontRange.addEventListener(
+          'change', this.standardRangeChanged_.bind(this, standardFontRange));
+      standardFontRange.customChangeHandler =
+          this.standardFontSizeChanged_.bind(standardFontRange);
 
       var minimumFontRange = $('minimum-font-size');
       minimumFontRange.valueMap = [6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17,
           18, 20, 22, 24];
-      minimumFontRange.continuous = false;
-      minimumFontRange.notifyChange = this.minimumRangeChanged_.bind(this);
-      minimumFontRange.notifyPrefChange =
-          this.minimumFontSizeChanged_.bind(this);
+      minimumFontRange.addEventListener(
+          'change', this.minimumRangeChanged_.bind(this, minimumFontRange));
+      minimumFontRange.customChangeHandler =
+          this.minimumFontSizeChanged_.bind(minimumFontRange);
 
       var placeholder = loadTimeData.getString('fontSettingsPlaceholder');
       var elements = [$('standard-font-family'), $('serif-font-family'),
                       $('sans-serif-font-family'), $('fixed-font-family'),
                       $('font-encoding')];
       elements.forEach(function(el) {
         el.appendChild(new Option(placeholder));
         el.setDisabled('noFontsAvailable', true);
       });
 
@@ skipping 10 matching lines @@
       // loaded for the first time.  This makes opening the options window
       // faster and consume less memory if the user never opens the fonts
       // dialog.
       if (!this.hasShown) {
         chrome.send('fetchFontsData');
         this.hasShown = true;
       }
     },
 
     /**
-     * Called as the user changes the standard font size.  This allows for
-     * reflecting the change in the UI before the preference has been changed.
+     * Handler that is called when the user changes the position of the standard
+     * font size slider. This allows the UI to show a preview of the change
+     * before the slider has been released and the associated prefs updated.
      * @param {Element} el The slider input element.
-     * @param {number} value The mapped value currently set by the slider.
+     * @param {Event} event Change event.
      * @private
      */
-    standardRangeChanged_: function(el, value) {
+    standardRangeChanged_: function(el, event) {
+      var value = el.mapValueToRange(el.value);
       var fontSampleEl = $('standard-font-sample');
       this.setUpFontSample_(fontSampleEl, value, fontSampleEl.style.fontFamily,
                             true);
 
       fontSampleEl = $('serif-font-sample');
       this.setUpFontSample_(fontSampleEl, value, fontSampleEl.style.fontFamily,
                             true);
 
       fontSampleEl = $('sans-serif-font-sample');
       this.setUpFontSample_(fontSampleEl, value, fontSampleEl.style.fontFamily,
                             true);
 
       fontSampleEl = $('fixed-font-sample');
       this.setUpFontSample_(fontSampleEl,
                             value - OptionsPage.SIZE_DIFFERENCE_FIXED_STANDARD,
                             fontSampleEl.style.fontFamily, false);
     },
 
     /**
-     * Sets the 'default_fixed_font_size' preference when the standard font
-     * size has been changed by the user.
-     * @param {Element} el The slider input element.
-     * @param {number} value The mapped value that has been saved.
+     * Sets the 'default_fixed_font_size' preference when the user changes the
+     * standard font size.
+     * @param {Event} event Change event.
      * @private
      */
-    standardFontSizeChanged_: function(el, value) {
+    standardFontSizeChanged_: function(event) {
+      var value = this.mapValueToRange(this.value);
       Preferences.setIntegerPref(
         'webkit.webprefs.default_fixed_font_size',
-        value - OptionsPage.SIZE_DIFFERENCE_FIXED_STANDARD, '');
+        value - OptionsPage.SIZE_DIFFERENCE_FIXED_STANDARD, true);
+      return false;
     },
 
     /**
-     * Called as the user changes the miniumum font size.  This allows for
-     * reflecting the change in the UI before the preference has been changed.
+     * Handler that is called when the user changes the position of the minimum
+     * font size slider. This allows the UI to show a preview of the change
+     * before the slider has been released and the associated prefs updated.
      * @param {Element} el The slider input element.
-     * @param {number} value The mapped value currently set by the slider.
+     * @param {Event} event Change event.
      * @private
      */
-    minimumRangeChanged_: function(el, value) {
+    minimumRangeChanged_: function(el, event) {
+      var value = el.mapValueToRange(el.value);
       var fontSampleEl = $('minimum-font-sample');
       this.setUpFontSample_(fontSampleEl, value, fontSampleEl.style.fontFamily,
                             true);
     },
 
     /**
-     * Sets the 'minimum_logical_font_size' preference when the minimum font
-     * size has been changed by the user.
-     * @param {Element} el The slider input element.
-     * @param {number} value The mapped value that has been saved.
+     * Sets the 'minimum_logical_font_size' preference when the user changes the
+     * minimum font size.
+     * @param {Event} event Change event.
      * @private
      */
-    minimumFontSizeChanged_: function(el, value) {
+    minimumFontSizeChanged_: function(event) {
+      var value = this.mapValueToRange(this.value);
       Preferences.setIntegerPref(
-        'webkit.webprefs.minimum_logical_font_size', value, '');
+        'webkit.webprefs.minimum_logical_font_size', value, true);
+      return false;
     },
 
     /**
      * Sets the text, font size and font family of the sample text.
      * @param {Element} el The div containing the sample text.
      * @param {number} size The font size of the sample text.
      * @param {string} font The font family of the sample text.
      * @param {bool} showSize True if the font size should appear in the sample.
      * @private
      */
@@ skipping 79 matching lines @@
     FontSettings.getInstance().setUpFontSample_($('minimum-font-sample'), size,
                                                 null, true);
   };
 
   // Export
   return {
     FontSettings: FontSettings
   };
 });