Move handling of dialog preferences to Preferences class

chrome/browser/resources/options/controlled_setting.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var Preferences = options.Preferences;
 
   /**
    * A controlled setting indicator that can be placed on a setting as an
    * indicator that the value is controlled by some external entity such as
@@ skipping 91 matching lines @@
       if (self.controlledBy == 'recommended' && pref) {
         var container = doc.createElement('div');
         var action = doc.createElement('button');
         action.classList.add('link-button');
         action.classList.add('controlled-setting-bubble-action');
         action.textContent =
             loadTimeData.getString('controlledSettingApplyRecommendation');
         action.addEventListener(
             'click',
             function(e) {
-              Preferences.clearPref(pref);
+              Preferences.clearPref(pref, self.dialogPref);
             });
         container.appendChild(action);
         bubbleText.appendChild(container);
       }
 
       bubbleContainer.appendChild(bubbleText);
 
       // One-time bubble-closing event handler.
       self.closeHandler_ = this.close.bind(this);
       doc.addEventListener('click', self.closeHandler_, true);
     }
   };
 
   /**
    * The controlling entity of the setting. Can take the values "policy",
    * "extension", "recommended" or be unset.
    */
   cr.defineProperty(ControlledSettingIndicator, 'controlledBy',
                     cr.PropertyKind.ATTR,
                     ControlledSettingIndicator.prototype.close);
 
+  /**
+   * A special preference type specific to dialogs. Changes take effect in the
+   * settings UI immediately but are only actually committed when the user
+   * confirms the dialog. If the user cancels the dialog instead, the changes
+   * are rolled back in the settings UI and never committed.
+   * @type {boolean}
+   */
+  cr.defineProperty(ControlledSettingIndicator, 'dialogPref',
+                    cr.PropertyKind.BOOL_ATTR);
+
   // Export.
   return {
     ControlledSettingIndicator: ControlledSettingIndicator
   };
 });