Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 10827134: Include chromium_net.jar in unit_tests_apk. (Closed)

Created:
8 years, 4 months ago by nilesh
Modified:
8 years, 4 months ago
Reviewers:
bulach, sky
CC:
chromium-reviews
Visibility:
Public.

Description

Include chromium_net.jar in unit_tests_apk. Also Register JNI before running unit_tests on Android. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149650

Patch Set 1 #

Patch Set 2 : Moved to chrome_test_suite.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/chrome_tests.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
nilesh
Hi Scott, Can you please help review this. Adding Marcus as an Android reviewer.
8 years, 4 months ago (2012-08-02 07:46:33 UTC) #1
bulach
android lgtm, thanks!
8 years, 4 months ago (2012-08-02 12:03:06 UTC) #2
sky
Would this make more sense in one of the test suite files?
8 years, 4 months ago (2012-08-02 15:03:21 UTC) #3
nilesh
On 2012/08/02 15:03:21, sky wrote: > Would this make more sense in one of the ...
8 years, 4 months ago (2012-08-02 15:43:29 UTC) #4
sky
LGTM
8 years, 4 months ago (2012-08-02 16:00:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10827134/4001
8 years, 4 months ago (2012-08-02 16:06:04 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 17:33:05 UTC) #7
Change committed as 149650

Powered by Google App Engine
This is Rietveld 408576698