Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 10827132: Remove an unnecessary leak annotation. (Closed)

Created:
8 years, 4 months ago by kaiwang
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), erikwright (departed), MAD, pam+watch_chromium.org, timurrrr+watch_chromium.org, brettw-cc_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Remove an unnecessary leak annotation. Add memory leak suppressing for StatisticsRecorderTest. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149989

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M base/metrics/statistics_recorder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jar (doing other things)
lgtm
8 years, 4 months ago (2012-08-03 21:33:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaiwang@chromium.org/10827132/1
8 years, 4 months ago (2012-08-03 21:55:57 UTC) #2
commit-bot: I haz the power
Change committed as 149989
8 years, 4 months ago (2012-08-04 01:15:09 UTC) #3
Alexander Potapenko
Kai, Jim, can you elaborate on why the leak annotation is unnecessary here?
8 years, 4 months ago (2012-08-06 12:48:18 UTC) #4
kaiwang
See http://src.chromium.org/viewvc/chrome/trunk/src/base/debug/leak_annotations.h?revision=146163&content-type=text%2Fplain ANNOTATE_LEAKING_OBJECT_PTR will annotate the object and all objects referenced by it as intentional ...
8 years, 4 months ago (2012-08-06 22:10:35 UTC) #5
Alexander Potapenko
Am I missing something? Where is checksum_matching_list annotated as such?
8 years, 4 months ago (2012-08-07 10:08:56 UTC) #6
kaiwang
On 2012/08/07 10:08:56, Alexander Potapenko wrote: > Am I missing something? Where is checksum_matching_list annotated ...
8 years, 4 months ago (2012-08-07 20:09:37 UTC) #7
Alexander Potapenko
8 years, 4 months ago (2012-08-08 09:30:19 UTC) #8
Oh, you're right. Sorry for being inattentive.

Powered by Google App Engine
This is Rietveld 408576698