Refactoring the SysInfoProvider.

chrome/browser/chromeos/system/syslogs_fetcher_factory.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_SYSTEM_SYSLOGS_FETCHER_FACTORY_H_
+#define CHROME_BROWSER_CHROMEOS_SYSTEM_SYSLOGS_FETCHER_FACTORY_H_
+
+#include <string>
+#include <vector>
+
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/callback.h"
+#include "base/memory/singleton.h"
+#include "base/synchronization/lock.h"

[rkc1, 2012/08/04 01:15:05]

Don't need several of these headers.

[tudalex(Chromium), 2012/08/05 01:15:12]

Done.

+#include "chrome/browser/chromeos/system/syslogs_fetcher.h"

[rkc1, 2012/08/04 01:15:05]

Replace this include with,

class SysLogFetcher;

move the include to the .cc file.

[tudalex(Chromium), 2012/08/05 01:15:12]

Done.

+
+namespace chromeos {
+namespace system {

[rkc1, 2012/08/04 01:15:05]

This namespace is unnecessary.
Also, move the logs code to chrome/browser/chromeos/syslogs

[tudalex(Chromium), 2012/08/05 01:15:12]

Done.

+
+class SysLogsFetcherFactory {
+ public:
+    static SysLogsFetcherFactory* GetInstance();
+    SysLogsFetcher * GetFetcher();

[rkc1, 2012/08/04 01:15:05]

SysLogsFetcher*

[tudalex(Chromium), 2012/08/05 01:15:12]

Done.

+
+ private:
+    SysLogsFetcherFactory()  {}
+    ~SysLogsFetcherFactory() {}

[rkc1, 2012/08/04 01:15:05]

Run Clang bots to make sure this is kosher.

[tudalex(Chromium), 2012/08/05 01:15:12]

Need rights first.

+    friend struct DefaultSingletonTraits<SysLogsFetcherFactory>;
+};
+
+}  // namespace system
+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_CHROMEOS_SYSTEM_SYSLOGS_FETCHER_FACTORY_H_