Refactoring the SysInfoProvider.

chrome/browser/chromeos/system/memorydetails_fetcher.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/system/memorydetails_fetcher.h"
+
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/command_line.h"
+#include "base/file_path.h"
+#include "base/file_util.h"
+#include "base/logging.h"
+#include "base/string_util.h"
+#include "base/memory/singleton.h"
+#include "base/memory/weak_ptr.h"
+#include "base/threading/thread.h"
+#include "chrome/browser/chromeos/system/syslogs_fetcher.h"
+#include "chrome/browser/memory_details.h"
+#include "content/public/browser/browser_thread.h"
+
+namespace chromeos {
+namespace system {
+
+class SysLogsFetcherMemoryHandler : public MemoryDetails {
+ public:
+
+  SysLogsFetcherMemoryHandler(
+      SysLogsFetcherCallback request)
+      : request_(request) { }
+
+  virtual void OnDetailsAvailable() OVERRIDE {
+    SysInfoResponse* response = new SysInfoResponse;
+    (*response)["mem_usage"] = ToLogString();
+    // This will call the callback on the calling thread.
+    request_.Run(response);
+  }
+
+ private:
+  virtual ~SysLogsFetcherMemoryHandler() {}
+    SysLogsFetcherCallback request_;

[rkc1, 2012/08/04 01:15:05]

Indentation.

[tudalex(Chromium), 2012/08/05 01:15:12]

Done.

+    DISALLOW_COPY_AND_ASSIGN(SysLogsFetcherMemoryHandler);

[rkc1, 2012/08/04 01:15:05]

Newline above.

[tudalex(Chromium), 2012/08/05 01:15:12]

Done.

+  };
+
+void MemoryDetailsFetcher::Fetch(SysLogsFetcherCallback request){
+  scoped_refptr<SysLogsFetcherMemoryHandler>
+      handler(new SysLogsFetcherMemoryHandler(request));
+  // TODO(jamescook): Maybe we don't need to update histograms here?
+  handler->StartFetch(MemoryDetails::UPDATE_USER_METRICS);
+}
+
+}  // namespace system
+}  // namespace chromeos