Refactoring the SysInfoProvider.

chrome/browser/chromeos/system_logs/lsb_release_log_source.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+#ifndef CHROME_BROWSER_CHROMEOS_SYSTEM_LOGS_LSB_RELEASE_LOG_SOURCE_H_
+#define CHROME_BROWSER_CHROMEOS_SYSTEM_LOGS_LSB_RELEASE_LOG_SOURCE_H_
+
+#include "chrome/browser/chromeos/system_logs/system_logs_fetcher.h"
+
+namespace chromeos {
+
+// Fetches release information form /etc/lsb-release file.
+class LsbReleaseLogSource : public SystemLogsSource {
+ public:
+  LsbReleaseLogSource() {}
+  virtual ~LsbReleaseLogSource() {}
+
+  // SystemLogsSource override.
+  virtual void Fetch(const SysLogsSourceCallback& callback) OVERRIDE;
+
+  // For testing. Parses a key=value pairs from a string. There can be only one
+  // pair per line and the value must confine to a single line.
+  // Example:
+  // foo = 1
+  // bar = 2
+  // Note: it automatically strips whitespaces from the front and back of values
+  // and keys.
+  static void ParseLSBRelease(const std::string& lsb_data,
+                              SystemLogsResponse* response);
+
+ private:
+  // Gets the info from the /etc/lsb-release and parses it
+  static void ReadLSBRelease(SystemLogsResponse* response);

[Lei Zhang, 2012/08/21 19:56:55]

Put this in an anonymous namespace instead and remove it from the header?

[rkc1, 2012/08/21 20:02:33]

This has been discussed extensively; it really doesn't matter if we leave it in
the class and it might be useful for unit testing it later.

[Lei Zhang, 2012/08/21 20:08:15]

Which I did not read given the number of iterations on this CL. Fine by me.

+
+  DISALLOW_COPY_AND_ASSIGN(LsbReleaseLogSource);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_CHROMEOS_SYSTEM_LOGS_LSB_RELEASE_LOG_SOURCE_H_